Flow type components

It would be great to get more flow coverage over our components. Here’s a list of components that don’t have Flow in them. The docs for flow are pretty great. This would be great to tag team. If you want to grab a component comment below and we’ll assign it to you. If you have any questions hit us up on Slack in the #perf or in this issue.

• /components

  • /components/app

    • Initializing.js (taken by @piq9117)
    • ProfileFilterNavigator.js (taken by @DanielNill)
    • ProfileSharing.js (taken by @DanielNill)
    • TabBar.js (taken by @derekm)

  • /components/calltree

    • FilterNavigatorBar.js (taken by @brisad)
    • ProfileCallTreeFilterNavigator.js (taken by @brisad)
    • ProfileCallTreeView.js (taken by @brisad)

  • /components/header

    • OverflowEdgeIndicator.js (taken by @brisad)
    • ProfileThreadJankOverview.js (taken by @brisad)
    • ProfileThreadTracingMarkerOverview.js (taken by @brisad)
    • SelectionScrubberOverlay.js (taken by @brisad)
    • ThreadMarkerOverlay.js (taken by @brisad)
    • ThreadStackGraph.js
    • TimeRuler.js
    • TimeSelectionScrubber.js

  • /components/log

    • ProfileLogView.js (taken by @piq9117)

  • /components/marker-table

    • index.js (taken by @piq9117)

  • /components/shared

    • ArrowPanel.js
    • ButtonWithPanel.js
    • Draggable.js
    • StyleDef.js
    • VirtualList.js
    • WithSize.js

[gregtatum]

🎉 Thanks @brisad and @derekm for the successfully merged PRs! Let me know if you all want to take any more components.

Also @DanielNill feel free to submit a PR for any work in progress if you want to get any help or feedback at this point. Nothing has to look pretty and it’s a good way for me quickly provide some insight into any hiccups.

[julienw]

Thanks ! You can create PR early if you have any question or need feedback ! Our data structures aren’t easy 😉

As general guidance, we try to avoid any as much as possible – removing existing one when we find some too.