question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The network chart shouldn't use the marker search string

See original GitHub issue

STR:

  1. open https://perf-html.io/public/4666336db7dd9445d1cc8deb53e861c62cb326db/marker-chart/?globalTrackOrder=4-0-1-2-3&hiddenGlobalTracks=1-2&thread=0&v=3
  2. search for some markers, eg using Reflow
  3. switch to the Network panel

=> the view shouldn’t be filtered using the same value.

The work to do here is:

  • add a new redux state for this string (including actions / reducers / selectors)
  • create a component for this settings, following the example of MarkerSettings but using the new redux state instead.
  • use this component in the component network-chart/index.
  • properly serialize the new redux state in url-handling.js.
  • add new tests for all this new behavior.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:12 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
ThobyVcommented, Feb 27, 2019

I am sorry I did not have the chance to see a comment notification. Anyways I am working on it! I will ask questions here.

0reactions
canovacommented, Apr 1, 2019

This is fixed by #1843. Closing.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to add a value marker to JavaFX chart? - Stack Overflow
To convert chart values to pixels you can use method NumberAxis#getDisplayPosition() which return actual coordinates of the chart nodes.
Read more >
ROBLOX FIND THE MARKERS... (All 150 Markers) - YouTube
KreekCraft finds all 150 Markers in Roblox Find the Markers..❤️ HELP ME REACH 4 MILLION SUBSCRIBERS: ...
Read more >
Geocoding Service | Maps JavaScript API - Google Developers
You can also use the geocoder to find the address for a given place ID. ... map.setCenter(results[0].geometry.location); var marker = new google.maps.
Read more >
Wireshark User's Guide
Wireshark is the world's foremost network protocol analyzer, but the rich feature ... The following table shows the typographic conventions that are used...
Read more >
Networking | Elasticsearch Guide [8.5] | Elastic
They are not required in most cases and you should not use them if you can use the commonly used settings instead. network.bind_host:...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found