Can't get pyinfra work with ssh

Describe the bug

Similarly to #671, trying to access a server via the pyinfra ssh operator I keep getting the error “Host key verification failed”.

I’m not sure it’s a bug or rather I’m doing something wrong.

To Reproduce

inventory.py

home_devices = [
    ('tk',{
        'ssh_port': 22,
        'ssh_user': 'paolo',
        'ssh_key': '~/.ssh/foo/id_ed25519_tk',
        'ssh_key_password': '',
    }),
]

deploy.py

from pyinfra.operations import ssh

ssh.command(
    name='System uptime',
    user='paolo',
    hostname='tk',
    command='uptime',
)

Run with:

$ pyinfra inventory.py deploy.py -vvv --debug

I also tried to run pyinfra tk deploy.py -vvv --debug without positive results.

Output:

$ pyinfra tk deploy.py -vvv --debug
    [pyinfra_cli.main] Checking potential directory: 
    [pyinfra_cli.main] Deploy directory remains as cwd
--> Loading config...
--> Loading inventory...
    [pyinfra_cli.inventory] Creating fake inventory...

--> Connecting to hosts...
    [pyinfra.api.connectors.ssh] Connecting to: tk ({'allow_agent': True, 'look_for_keys': True, 'hostname': 'tk', 'timeout': 10})
    [tk] Connected
    [pyinfra.api.state] Activating host: tk

--> Preparing operations...
    Loading: deploy.py
    [pyinfra.api.operation] Adding operation, {'System uptime'}, opOrder=(3,), opHash=_________________
    [tk] Ready: deploy.py

--> Proposed changes:
    Ungrouped:
    [tk]   Operations: 1   Commands: 1   

--> Beginning operation run...
--> Starting operation: System uptime 
    [pyinfra.api.operations] Starting operation System uptime on tk
    [pyinfra.api.connectors.ssh] Running command on tk: (pty=None) sh -c 'ssh -p 22 paolo@tk uptime'
[tk] >>> sh -c 'ssh -p 22 paolo@tk uptime'
[tk] Host key verification failed.
    [pyinfra.api.connectors.ssh] Waiting for exit status...
    [pyinfra.api.connectors.ssh] Command exit status: 255
    [tk] Error
    [pyinfra.api.state] Failing hosts: tk
--> pyinfra error: No hosts remaining!

Note 1: if I directly type sh -c 'ssh -p 22 paolo@tk uptime' everything works

Note 2: I have this entry in .ssh/config

Host tk
  User paolo
  HostName tk
  IdentityFile ~/.ssh/foo/id_ed25519_tk

Commenting those lines the output changes to

--> Connecting to hosts...
    [pyinfra.api.connectors.ssh] Connecting to: tk ({'allow_agent': True, 'look_for_keys': True, 'hostname': 'tk', 'timeout': 10})
    [tk] Authentication error ()
    [pyinfra.api.state] Failing hosts: tk
--> pyinfra error: No hosts remaining!

Note 3: removing the key with ssh-keygen -R tk, pyinfra correctly recognize that

...
--> Connecting to hosts...
    [pyinfra.api.connectors.ssh] Connecting to: tk ({'allow_agent': True, 'look_for_keys': True, 'hostname': 'tk', 'timeout': 10})
    No host key for tk found in known_hosts
    [tk] Connected
    [pyinfra.api.state] Activating host: tk
...

Expected behavior

SSH connection to the remote host should happen without errors.

Meta

pyinfra --support

--> Support information:

    If you are having issues with pyinfra or wish to make feature requests, please
    check out the GitHub issues at https://github.com/Fizzadar/pyinfra/issues .
    When adding an issue, be sure to include the following:

    System: Linux
      Platform: Linux-5.11.0-37-generic-x86_64-with-glibc2.29
      Release: 5.11.0-37-generic
      Machine: x86_64
    pyinfra: v1.4.17
    Executable: /home/paolo/tmpvenv/bin/pyinfra
    Python: 3.8.12 (CPython, GCC 9.3.0)

pyinfra was installed with pip

$ pip install -U pip
$ pip install pyinfra

$ pip freeze
bcrypt==3.2.0
certifi==2021.10.8
cffi==1.15.0
charset-normalizer==2.0.7
click==8.0.3
colorama==0.4.4
configparser==5.0.2
cryptography==35.0.0
distro==1.5.0
gevent==21.8.0
greenlet==1.1.2
idna==3.3
Jinja2==3.0.2
MarkupSafe==2.0.1
ntlm-auth==1.5.0
paramiko==2.8.0
pycparser==2.20
pyinfra==1.4.17
PyNaCl==1.4.0
python-dateutil==2.8.2
pywinrm==0.4.2
requests==2.26.0
requests-ntlm==1.1.0
six==1.16.0
urllib3==1.26.7
xmltodict==0.12.0
zope.event==4.5.0
zope.interface==5.4.0

[paolodina]

@Fizzadar thankyou very much. It was my fault, works like a charm now! For me the issue is solved, close if you like.

[Fizzadar]

I’m going to close this issue now as it’s diverged from the original problem. There have been improvements to the auth error handling since that should display the underlying authentication issue if there is any. If needed please open another issue and we’ll get things sorted 😃