Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Explicit imports for facts

See original GitHub issue

Currently facts are loaded “by magic” into a global namespace (available via host.fact.X). Importing a module containing a fact automatically adds it to the fact list while converting the camel cased class name into snake case. This presents a few issues:

Potential for custom facts to override builtin facts
Hard to understand what facts are available/loaded
Linting/type checking hard/impossible

Potential alternative API:

from pyinfra import host
from pyinfra.facts.apt import AptSources


# Legacy
sources = host.fact.apt_sources

# New
sources = host.get_fact(AptSources)

Issue Analytics

State:
Created 3 years ago
Comments:6 (5 by maintainers)

Top GitHub Comments

2reactions

Fizzadarcommented, Jan 7, 2021

Ah yes, good point - entrypoints would work well I think. I’m not against simply removing all facts as well, I think it’s a bit of an edge case and having the explicit imports removes all the magic entirely (and makes facts consistent with external/custom operations).

1reaction

Fizzadarcommented, Apr 29, 2021

This has now been released in v1.4!