Pyinfra tries to collect postgresql fact on wrong host

Describe the bug

While running postgresql.PostgresqlDatabases fact, pyinfra does not take into consideration postgresql_host conditional logic.

To Reproduce

databases = host.get_fact(postgresql.PostgresqlDatabases, postgresql_user="admin", postgresql_password="admin",
                          postgresql_host="localhost" if host.data.node=="master" else "192.168.56.10")

Here is the error log:

psql: error: connection to server at "localhost" (127.0.0.1), port 5432 failed: Connection refused
    [192.168.56.11]     Is the server running on that host and accepting TCP/IP connections?

Expected behavior

With the fact collection above, pyinfra would not run the conditional logic for host selection, and default to host as localhost regardless of which server it is running on. Since one of the servers, I am targeting, is running the postgres its host needs to be localhost, while others are not running postgres and thus the host they use to connect to postgres needs to be different (ip in this case). Thus, I would expect that the conditional logic in postgresql_host field is respected when choosing a host to connect to.

Meta

• Include output of pyinfra --support.
• How was pyinfra installed (source/pip)? pip
• Include pyinfra-debug.log (if one was created)
• Consider including output with -vv and --debug.

[PermanAtayev]

@PermanAtayev my apologies - my workaround actually has exactly the same issue. The fact will always be executed on all hosts. A quick hack for now could be to ignore errors:

host.get_fact(postgresql.PostgresqlDatabases, su_user="postgres", ignore_errors=True)

This should get you going. Alternatively you could try out v2.0.dev0 which should properly resolve this issue. This is an unfortunate gotcha with the way v1 generates operations.

I will check v2.0.dev0 because ignoring errors is not really an option. Thank you 😃

[Fizzadar]

v2 is now out which should resolve this, please re-open or make a new issue if there are still problems 😃