broken ToastContainers with enableMultiContainer and one unmounted ToastContainer
See original GitHub issueFirst, thank you very much to all contributors!
Do you want to request a feature or report a bug? report a bug
What is the current behavior?
eventManager.off(ACTION.SHOW).off(ACTION.CLEAR).emit(ACTION.WILL_UNMOUNT, this);
which will be triggered on componentWillUnmount
of a ToastContainer
removes event-handlers of all ToastContainer
and not only the event-handlers for the ToastContainer
which will be unmounted. Unfortunately this (one global and multiple ToastContainers) is exactly my use case.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn’t have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below: Demo: https://codesandbox.io/embed/react-toastify-with-multiple-toastcontainer-21t16
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (3 by maintainers)
Top GitHub Comments
Hey the v5.4.1 fix the issue.
Works. Again, thank you very much!