question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Shouldn't `react` and `react-dom` be listed as peer dependencies?

See original GitHub issue

react is currently a normal dependency, and react-dom a development one. Shouldn’t they be listed as peer dependencies?

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
fkhadracommented, May 11, 2017

Thanks for the precision, I understand better know 😁. I’ll fix it tonight.

0reactions
fkhadracommented, May 11, 2017

@lorenzos package updated thanks for the advice !

Read more comments on GitHub >

github_iconTop Results From Across the Web

what should be peer dependencies when creating libs in ...
React/ReactDOM definitely needs to be a peer dependency. If set in dependencies and the user has a different version installed than you ...
Read more >
react, react-dom and prop-types shouldn't be dependencies #20
But it shouldn't. react and react-dom should be required in peerDependencies , and just imported as devDependency if you need to run tests, ......
Read more >
package.json - npm Docs
It's a string. This helps people discover your package, as it's listed in npm search . ... As of npm v7, peerDependencies are...
Read more >
Addressing the shortcomings of peer dependencies - HackMD
When middle tier libraries say react and react-dom are peers, their intent is to avoid being the source of a duplicate when semver...
Read more >
Understanding Dev, Peer, and Regular Dependencies
dependencies are packages used in your app's production bundle. If you're building a React app, then react and react-dom would be dependencies.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found