Arrays are converted to objects

Describe the bug Currently when translating JSON files from source to target, it converts any arrays inside the source JSON files to object representations of such like so from:

"address": {
    "lines": [
        "Line 1",
        "Line 2",
        "Line 3"
    ]
},

to

"address": {
  "lines": {
    "0": "Line 1",
    "1": "Line 2",
    "2": "Line 3"
  }
},

To Reproduce

1. Create a new source JSON file containing an array
2. Convert the JSON file to another language

Expected behavior The expected behavior would be that the datatype stays the same.

Files This could be done using any simple JSON file containing the above example content.

Additional context N/A

[fkirc]

I agree with your conclusions, we should probably replace the entire nested-json implementation with a recursive implementation, similar to the recursive YAML-implementation which is already working well.

The original intention behind the flat translation map was to (1.) provide a unified interface for all file-formats and (2.) enable cross-format-translations. I think that this interface is still working because the individual file-formats are free to cache the entire source-file. In other words, the source-JSON-file can remain in memory for a recursive string-replacement-procedure.

[dwknippers]

Hey thanks so much, seems to be a much more robust implementation! 🌟 Sorry I couldn’t spend much time on this, but the PR is solid work!