Flakeheaven ignores baseline when using absolute path to file

flakeheaven lint filename.py is clean because of baseline, but flakeheaven lint $(basename filename.py) gives errors.

As a minimal example, save the following file as flake8heavened

#!/usr/bin/env python
# -*- coding: utf-8 -*-
import re
import sys
from flakeheaven import flake8_entrypoint
if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
    sys.exit(flake8_entrypoint())

Run flakeheaven baseline flake8helled >> .flakeheaven_baseline Then flakeheaven lint flake8helled is clean, but flakeheaven lint $(realpath flake8helled) is not.

This is an issue because VS Code (and may be other IDEs) use the absolute path to the files.

[snmishra]

@mcarans Thanks for merging in record time!

[snmishra]

@mcarans I never used flakehell. I did try flakehell, but it was incompatible with flake8 4.0.0, discovered flakeheaven. The relevant code appears to be identical in flakehell.

I don’t think this is a bug, but a limitation of how the baseline is calculated. Currently, the filename is hashed as is, without considering whether it’s a relative or an absolute path. I wanted to check-in the baseline to git so we can share it across all developers. Since every developer will have a different abspath, it makes sense to use relative paths.

Unfortunately, VS Code (I haven’t checked other IDEs) uses absolute path to run the flake8 checks, which means the baseline file is ignored in the integration. Command-line works fine, of course.