General Tasks

Hello again @flaport,

I 've been reading through the code, and I have suggestions (that I could also possibly implement):

1. Automate tests through github Actions. (I ve actually already implemented a PoC on my fork - will open a PR). In the future Actions can also be used for publishing docs and the package itself on pypi.

2. Some (minor?) code refactoring, hopefully without having to change the current API at all. An example of what I have in mind is changing this to a class factory and generally some clarity changes.

3. [edit] I would also suggest using another branch for active development/merges were changes are frequent (dev/staging?) and using master as a definitive branch for releases.

Looking forward to your thoughts on the above and more 😃

[iakovts]

Hey @flaport, sorry for the late response. Oops I didn’t realize that for the numpy slices (even though it’s something I’m actually using a lot - just didn’t put 2 and 2 together till now haha). Ok, I ll keep working on the boundaries and open a PR when ready!

[flaport]

thanks @iakovts, this looks good!

I think there should be a way around setting self.__class__, which I must admit I also don’t like very much. I can have a look after merging this.

For numpy arrays slice(None) at the end of the tuple is equivalent with not adding it at all (e.g. think of x[:, :] vs x[:] for a 2D array). However, it’s probably better to be more explicit here as well and add it for completeness.