External yml with flask_restful method

Is this an expected behaviour?

This works:

class todo(Resource):
    def get(self, todo_id):
        """
        file: todo_get.yml
        """
        abort_if_todo_doesnt_exist(todo_id)
        return TODOS[todo_id]

This:

from flasgger import swag_from

class todo(Resource):
    @swag_from('todo_get.yml', validation=True)
    def get(self, todo_id):
        abort_if_todo_doesnt_exist(todo_id)
        return TODOS[todo_id]

Gives: Code: 200 Data: { “message”: null }

[juliencuvillier]

Hi, I have the same issue here, using manual validation

Response is:

{"message": null}

When using this code:

class ChronosAddRequest(Resource):

    @swag_from("swaggerdocs/chronos_post.yml")
    def post(self):
        validate(request.json, 'ChronosPost', 'swaggerdocs/chronos_post.yml')

Everything is fine when removing the validation step

[lindvall]

I’ve experienced a similar or same issue.

By changing the abort call in parse_request: https://github.com/flasgger/flasgger/blob/31c86c4db66b3e4d6446bb024cca50cf51652561/flasgger/base.py#L638

to:

abort(400, e.message)

It successfully returns the ValidationError message with the status code 400. I tried to figure out why it fails to abort with the Response object, but couldn’t find the cause.

However, for a better end user experience perhaps the try/except clause should be replaced by something like this?:

v = jsonschema.Draft7Validator(
    schemas[location], format_checker=self.format_checker)
errors = ['%s: %s' % (
    error.path.pop(), error.message) for error in v.iter_errors(data)]
if errors:
    abort(400, errors))

The formatting of the messages should perhaps be configured by the user, but this is just an example.