type object ... has no attribute ... when using formatters

Hi, i’m using formatters for a model :

    column_formatters = {
        'name': macro('name_formatter')
    }

With its template :

{% macro name_formatter(model, column) %}
  {{ model.firstname }} {{ model.lastname }}
{% endmacro %}

Since flask-admin 1.4.1, i get this exception when running my application :

Traceback (most recent call last):
  File "run.py", line 2, in <module>
    from backend import app
  File "/path/to/project/backend/__init__.py", line 68, in <module>
    admin.create_admin(app)
  File "/path/to/project/backend/views/admin.py", line 204, in create_admin
    admin.add_view(OrderModelView(Order, db.session))
  File "/path/to/project/lib/python2.7/site-packages/flask_admin/contrib/sqla/view.py", line 318, in __init__
    menu_icon_value=menu_icon_value)
  File "/path/to/project/lib/python2.7/site-packages/flask_admin/model/base.py", line 771, in __init__
    self._refresh_cache()
  File "/path/to/project/lib/python2.7/site-packages/flask_admin/model/base.py", line 847, in _refresh_cache
    self._list_columns = self.get_list_columns()
  File "/path/to/project/lib/python2.7/site-packages/flask_admin/model/base.py", line 980, in get_list_columns
    excluded_columns=self.column_exclude_list,
  File "/path/to/project/lib/python2.7/site-packages/flask_admin/contrib/sqla/view.py", line 517, in get_column_names
    column, path = tools.get_field_with_path(self.model, c)
  File "/path/to/project/lib/python2.7/site-packages/flask_admin/contrib/sqla/tools.py", line 144, in get_field_with_path
    value = getattr(current_model, attribute)
AttributeError: type object 'Order' has no attribute 'name'

Version 1.4.0 works well.

[mrjoes]

Ah! Now it makes sense. Never thought of using it that way.

OK, I’ll restore old behavior and release 1.4.2 with a bug fix today. I can’t think of better way of defining list of visible columns in one place even if they’re virtual.

[asfaltboy]

@mrjoes I would just like to mention that this behavior does not seem to be documented; and, in my opinion is extremely useful for setting “virtual” fields. A simple use case:

class Person(db.Model):
    # ...
    first_name = db.Column(db.String(64))
    last_name = db.Column(db.String(64))

    @property
    def full_name(self):
        return '{p.first_name} {p.last_name}'.format(p=self)


class Person(sqla.ModelView):
    column_list = ('full_name', )