After timeframe expires, best quality found is downloaded even if a better match to target is available

From http://flexget.com/ticket/3105

Consider a configuration such as

timeframe: 2 hours
target: 720p webdl
quality: 720p-1080p hdtv+

and the following scenario:

Flexget finds a suitable episode in two formats: 720p hdtv and 1080p hdtv, whether at the same time or within two hours of each other. Due to them not fulfilling the webdl requirement of the target quality it correctly doesn’t download anything yet.

The timeframe then expires and there is still no 720p webrip available.

At this point, Flexget’s current behaviour is to download the best quality it has seen, which in this case is the 1080p hdtv.

This may be what is wanted, but it also may not be. It’s not what I want, and I would imagine that most users would agree that in this scenario the 720p hdtv would be more appropriate, since the resolution matches the target and the source, though not matching the target, is in the valid quality range. On the other hand the 1080p hdtv, which was downloaded, does not match the target resolution (though it is in the valid range) and the source also does not match the target (though again it is in the valid range).

I think the default behaviour should be to match as many of the target requirements as possible, while of course staying within the quality requirements.

If it seems not all users would want this new default behaviour, it could be configurable. It could either be a “choose closest match: yes or no” option, or it could be more sophisticated with the “target” option expanded. A user who wants “720p webrip” could somehow specify that the 720p part is important, and the webrip part not so important, or some other such combination.

liiight asked in a comment on the old ticket:

if you don’t want 1080p to begin with? why even include it in the original requirement? if that is not a valid option on your part, do not include it.

i’m not saying i’m against adding a ‘closest match’ feature, that does sound interesting and doable, i’m just wondering.

The answer is that I do want 1080p if no 720p is available, but I prefer 720p. At present I have no way to tell Flexget that I prefer a “worse” quality, or rather I do since that’s what I’m saying in the “target”, but it isn’t taken into account when timeframe expires.

[mabo1]

Would the reorder_quality plugin solve this problem?

reorder_quality: 720p: above: 1080p

[liiight]

Please reopen in feathub