Can’t send email notification with full statistics including rejected and undecided entries (not only accepted/failed ones)

Expected behaviour:

notification with accepted|rejected|undecided|failed entries is sent

Actual behaviour:

notification with only accepted and failed entries is sent

Steps to reproduce:

• Step 1: add to tasks “digest” plugin with “accepted|rejected|undecided|failed” options
• Step 2: add “emailreport” task with “notify” and “from_digest” plugins and “restore_state: yes” option
• Step 3: execute tasks from step 1

Config example:

schedules:
  - tasks: 'task1'
    interval:
      hours: 2
  - tasks: 'task2'
    interval:
      hours: 4
  - tasks: 'emailreport'
    schedule:
      hour: 21
...
templates:
  ...
  video:
    digest:
        list: email_list
        state:
          - accepted
          - rejected
          - undecided
          - failed
...
tasks:
  task1:
    template:
      - video
...
  task2:
    template:
      - video
...
  emailreport:
    no_entries_ok: yes
    from_digest:
      list: email_list
      restore_state: yes
    seen: local

    notify:
      task:
        title: "[FLEXGET] Daily report"
        template: custom_html.template
        via:
          - email:
              from: '{? email.email_from ?}'
              to:
                - '{? email.email_to1 ?}'
                - '{? email.email_to2 ?}'
              smtp_host: smtp.gmail.com
              smtp_port: 587
              smtp_username: '{? email.smtp_username ?}'
              smtp_password: '{? email.smtp_password ?}'
              smtp_tls: yes
              html: yes

Log:

2017-01-26 21:00 VERBOSE  details       emailreport     Produced 586 entries.
2017-01-26 21:00 VERBOSE  manipulate    emailreport     Modified 0 entries.
2017-01-26 21:00 VERBOSE  details       emailreport     Summary - Accepted: 0 (Rejected: 1070 Undecided: 586 Failed: 0)
2017-01-26 21:00 WARNING  task          emailreport     Task doesn't have any output plugins, you should add (at least) one!
2017-01-26 21:00 VERBOSE  notify_entry  emailreport     No accepted or failed entries, not sending a notification.

Additional information:

• Flexget Version: 2.9.8
• Python Version: 2.7.12
• Installation method: pip
• OS and version: Ubuntu 16.04

P.S. As @liiight proposed maybe “always_send” should be added to the “notify” plugin

Related issue and FR in forum: https://discuss.flexget.com/t/cant-send-email-notification-with-full-statistics-including-rejected-and-undecided-entries-not-only-accepted-failed-ones/3129 https://discuss.flexget.com/t/add-always-send-option-to-notify-plugin/3130?source_topic_id=3129

[cvium]

I think adding a config option like

notify:
  when:
    - accepted
    - failed
    - rejected

would be better. It at least makes it clearer and the template is free to pull any entries.

[liiight]

@gazpachoking i wanna merge #1662. objections?