question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Logical offsets for start/end are not intuitive

See original GitHub issue

Note that this is not about rtl support -> that is actually awesome 🚀.

Just some examples to illustrate what I’m talking about

Popper v2: https://codesandbox.io/s/nervous-bird-xg963v?file=/src/index.js Floating UI: https://codesandbox.io/s/sad-hellman-drowyp?file=/src/index.js:451-465

I’ve noticed that offset axis now can invert based on alignment. This is not very intuitive since offset now needs to be correctly set based on the the placement that is chosen, i.e. the x,y axis changes orientation.

This is also a huge change from Popper. I can’t speak for all users of Popper, but for Microsoft, this will be a very painful breaking change since large applications like Teams will need to to completely reevaluate all the offsets in the app.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:16 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
atomikscommented, Mar 3, 2022

alignmentOffset could work, with crossAxis reverting back to how it worked in Popper v2

1reaction
FezVrastacommented, Mar 3, 2022

Maybe have a startOffset and endOffset instead?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Offset skidding value with *-start/*-end placements · Issue #1170
Bug: Tooltip offset-skidding not reversed in RTL layout Esri/calcite-components# ... Logical offsets for start/end are not intuitive #1560.
Read more >
Offset Indexing and Slicing - #104 by Michael_Ilseman - Pitches ...
I think I'm confused about what your objections are here. To me, there seems to be no problem at all with using .first...
Read more >
VCV Compare, Gates, Logic, and Process - Announcements
4 new built-in utilities for VCV Rack, available now! Compare: CV comparator and limiter; Gates: gate and trigger manipulator; Logic: binary ...
Read more >
Strange scale_x_datetime offset? - Google Groups
I think this is what Hadri's first solution was attempting to address - by adjusting the start/end points of the scale to the...
Read more >
2. Author's Guide - Clinical Quality Language (CQL)
This chapter introduces the high-level syntax for the Clinical Quality Language focused on measure and decision support authors.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found