question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`position` still applied when `applyStyle` modifier is disabled

See original GitHub issue

Hi @FezVrasta

When we disable applyStyle modifier it still append inline style (position: absolute)

CodePen demo

https://codepen.io/Johann-S/pen/jwVLGG

Steps to reproduce the problem

  1. Inspect the pop element and you’ll see inline style

What is the expected behavior?

Pop element shouldn’t have inline style

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:10 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
FezVrastacommented, Jun 19, 2017

The first adds more DOM manipulations, which may lead to worse performance, also, it doesn’t give full control over the DOM manipulation to the consumer… I’m more for the second option, mostly because, so far, Popper.js always preferred verbose but powerful configurations over “easy” but limiting ones.

I’d prefer the 3rd party wrappers to make the API simple to use, I hope it makes sense.

0reactions
souporseriouscommented, Jun 19, 2017

Makes way more sense, thanks for clarifying! 😃

I’m not too concerned with either approach. They both sound great in my opinion. If the first doesn’t seem to add any downside, but could be a better dev experience I vote for that 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

position still applied when applyStyle modifier is disabled #309
Hi @FezVrasta When we disable applyStyle modifier it still append inline style (position: absolute) CodePen demo ...
Read more >
popper.js shows up without any style - Stack Overflow
I used "popper.js" library ,it works properly but popup's don't have any style ( no background-color , no arrow , .. ) For...
Read more >
Popper (v1.×)
Modifier used to flip the popper's placement when it starts to overlap its reference element. Requires the preventOverflow modifier before it in order...
Read more >
popper.js - npm
Popper.js limits all its DOM modifications inside the applyStyle modifier, you can simply disable it and manually apply the popper ...
Read more >
disabled - CSS: Cascading Style Sheets - MDN Web Docs
The :disabled CSS pseudo-class represents any disabled element. An element is disabled if it can't be activated (selected, clicked on, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found