Request: Move popper.js dependency to peer-dependencies

Just kicking around the idea here… this is a wrapper project that should be generally forward compatible with non-breaking changes. That said, it is slightly annoying whenever I need to test popper.js@next functionality or worse yet, if a breaking change came with popper.js, I’m stuck with whatever build react-popper is on due to the direct dependency.

My suggestion is to change it to a peer dependency. This allows people who want to use an alternate version of popper.js to use it.

[jony89]

@souporserious popper-js totally should be a peerDependecy, for two main reasons :

1. testing, allow to easily mock popper-js (see https://github.com/FezVrasta/popper.js/issues/478 if u want to know why)
2. force to have only one instance of popper-js in the final bundle that is specified in the main project.

I think this issue should be open.

I can create a PR once I know the approach is acceptable

[jony89]

And my last comment as well :

it needs to have fine control over its version to be able to work properly.

Correct, and that’s exactly what peerDependency allows u to do 😃