Update TS typings for Popper

I’ve just update MUI next to beta 37 and with it popper at v1.14 (previously it was v1.12). But not the TS compiler would complain about wrong typings:

node_modules/react-popper/react-popper.d.ts(38,17): error TS2503: Cannot find namespace 'PopperJS'.

I guess instead of:

import PopperJS from "popper.js";
const v: PopperJS.Placement;

we should use:

import {Placement} from "popper.js";
const v: Placement;

or

import * as PopperJS from "popper.js";
const v: PopperJS.Placement;

[FezVrasta]

Oh fuck, I hate TypeScript, it’s so fucking cryptic… Would it be a solution if a dropped support for it from Popper.js completely? I can’t stand it anymore 😩

Bloody me and the day I decided to merge the TS support PR…

[rolandjitsu]

😆 @FezVrasta I don’t think you need to. Changing the way this lib declares the import should suffice. There is already a PR here that addresses the typings, it just needs to be changed slightly.

I’ve just testd with import * as PopperJS from "popper.js"; instead of import PopperJS from "popper.js"; and it seems to work.

Ideally you’d always import the necessary exported objects from the lib instead of everything:

// e.g.
import {Placement, Modifiers} from 'popper.js';