Crash occurs when opening the keyboard in landscape mode before portrait

Short description

If I initally open the keyboard in landscape mode it crashes. The crash doesn’t occur if I have opened in portrait mode first. It also doesn’t happen if landscape full screen input is set to never show.

Steps to reproduce

1. Make sure landscape full screen mode is not set to dynamically show or always show.
2. Close the Florisboard Beta app.
3. Reopen the app.
4. Rotate to landscape mode.
5. Open the keyboard.
6. See crash.

Environment information

• FlorisBoard Version: 0.3.15-rc01 (78)
• Device: HMD Global Nokia 7.1
• Android: 10 (cn=Q sdk=29)

Features enabled

smartbar = true
suggestions = false
suggestions_clipboard = true
suggestions_next_word = true
glide = false
clipboard_internal = false
clipboard_history = true

Attached stacktrace files

1649217207271.stacktrace

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.inputmethodservice.ExtractEditText.setIME(android.inputmethodservice.InputMethodService)' on a null object reference
	at android.inputmethodservice.InputMethodService.setExtractView(InputMethodService.java:1638)
	at android.inputmethodservice.InputMethodService.updateFullscreenMode(InputMethodService.java:1330)
	at dev.patrickgold.florisboard.FlorisImeService.updateFullscreenMode(FlorisImeService.kt:397)
	at android.inputmethodservice.InputMethodService.prepareWindow(InputMethodService.java:1934)
	at android.inputmethodservice.InputMethodService.showWindow(InputMethodService.java:1884)
	at android.inputmethodservice.InputMethodService$InputMethodImpl.showSoftInput(InputMethodService.java:638)
	at android.inputmethodservice.IInputMethodWrapper.executeMessage(IInputMethodWrapper.java:220)
	at com.android.internal.os.HandlerCaller$MyHandler.handleMessage(HandlerCaller.java:44)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7397)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)

[whatevenisthat]

It looks like it’s fixed. I’ve set it to always use extracted text view, opened and closed the Florisboard debug app and tried it in a bunch of different apps and text fields and I haven’t experienced the crash at all.

[patrickgold]

Thanks for testing out, will merge the changes in then and later release 0.3.15-rc02.