Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Possible to require package author review for libdef updates?

See original GitHub issue

In react-navigation we have a CI that tests our libdef against an example project. We ask that users submit their libdef changes first to our repo, so we can make sure they don’t break our example project. We then send PRs to flow-typed once the changes have been committed to our repo.

This adds a layer of testing beyond the tests in this repo and helps protect against breaking libdef changes.

However, individual package users have been sending PRs on our libdef in this repo, causing the libdef versions to get out-of-sync. Is it possible to restrict flow-typed PRs for a specific package to package authors, or alternately to require their reviews for any PRs on their packages?

Issue Analytics

State:
Created 6 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

Brianzchencommented, Oct 13, 2022

This is almost a reality stay tuned! Just waiting on some webhook setups but here’s the test PR to showcase

https://github.com/flow-typed/flow-typed/pull/4388#issuecomment-1275273086

1reaction

Brianzchencommented, Feb 1, 2022

We should look into a gitbot eventually that looks so files changes and tags appropriately though I don’t have experience in that realm. @GAntoine we could leverage the package.json from a flow version for this situation

Top Results From Across the Web

How should these definitions be consumed? · Issue #4 - GitHub

Adding a new library definition is as simple as sending a pull request that includes the libdef, a specification of the package-version the...

Package Review Process - Fedora Docs

In order for a new package to be added to Fedora, the package must first undertake a formal review. The process is governed...

lib/spack/docs/packaging_guide.rst - GitLab

Packages allow a the packager to encapsulate the build logic for different versions, compilers, options, platforms, and dependency combinations in one place.

User's Guide - IBM

If the order is fulfilled within the allowed time, the server sends SMP/E the information required to download the resultant package (FTP ...

Project IMPACT: Computer-Administered Instruction - ERIC

(HSSS) reflects a compromise between immediate and longer-range requirements. Off-the- shelf hardware and software components were used wherever possible, ...