[Test CI] Automatically comment on PRs that add `any` types
See original GitHub issueWe want the libdefs in this repository to remain high quality. As such, we want to minimize any
types as much as is reasonably possible. In some cases an any
type of some kind (including things like Object
, Function
, etc) is unavoidable – so we can’t simply ban them altogether.
To minimize the number of unnecessary any
types, it would be good to have Travis check for these and comment on any pull requests that add them – pointing out that they should be avoided if at all possible.
Perhaps something like a --strict
flag could be added to the validate-defs
command that emits warnings on these kinds of things?
Issue Analytics
- State:
- Created 7 years ago
- Comments:8 (7 by maintainers)
Top Results From Across the Web
How to auto comment on GitHub Pull Requests
The GitHub API supports the ability to add comments to open Pull Requests. With this in mind, you can utilize environment variables and...
Read more >reconsider posting CI comments on every test failure #3621
Currently Kubernetes PRs get a lot of comments from @k8s-ci-robot, many of which are to notify of failing tests.
Read more >How to add Playwright tests to your pull request CI with GitHub ...
I want to show you how to add Playwright tests to your PRs and how to tie it all together with a GitHub...
Read more >What are Github Actions and How Can You Automate Tests ...
What is CI/CD? What are we going to build? Part 0: Setting up a project; Part 1: Automating tests; Part 2: Post new...
Read more >Run the CI Pipeline during a Pull Request
I fixed my unit test, added a link to the PB, and fixed the suggested changes from the comment. The comment creator resolved...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I found [eslint-plugin-flowtype/no-weak-types]https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-no-weak-types and created a PR to this repo with config for that and will close my PR against eslint-plugin-flow-typed.
@jeffmo Looks like Hound CI has support for eslint and does inline comments of lint warnings. Might be an option?