Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update all tests with suppression codes

See original GitHub issue

Can we use the internal flow too to update all suppression codes in one go so that there’s less friction with new flow changes?

sainati Today at 10:38 AM
yes
you can use the tool script that comes with the repo
so ./tool add-comments <SUPPRESSION TEXT> will add suppression comments with the correct codes and that comment
and ./tool remove-comments will remove unused suppressions
this is what we do to upgrade our codebases internally

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:7 (7 by maintainers)

Top GitHub Comments

2reactions

jedwards1211commented, Dec 4, 2020

Oh, I guess some of those buggy warnings were happening in 0.125-0.126 and then fixed in later versions

1reaction

Brianzchencommented, Oct 26, 2020

I’ve run a test on this, you basically need to have both the flow and flow-typed repo’s cloned. Then you’ll need to install flow-bin in the definitions folder (which can be removed later prior to merging) and have flow on the same version.

Then in the flow repo, run, ./tool add-comments ../flow-typed/definitions where I encountered a few issues,

Because the imports are a bit random, it threw lots of module not found errors
Currently flow can’t handle adding suppression codes to existing comments, but the flow team will see if that ability can be open sourced