Windows issues

Now that Flow supports Windows (yay!), this probably should too.

2 issues I’m seeing so far:

First, the obvious one here, probably just needs the binary path added.

I tried to fix that locally, but I encountered another bigger issues: the file names. Git for Windows really didn’t seem to enjoy paths like flow_>=v0.28.x.

Don’t know what a good solution would be.

[jeffmo]

Ok, so to add some closure here I think we should go with:

flow_>=v0.30 -> flow_v0.30- flow_<=v0.30 -> flow_-v0.30 flow_v0.30 -> flow_v0.30 flow_>=v0.30_<=v0.35 -> flow_v0.30-v0.35.0

Since we already use _ to separate “name” from “version”, I think it’s best to have something clearly different. - also makes sense for indicating a range.

So I think the work that’s needed here goes as follows:

1. Codemod all the existing names in the repo to this new format
2. Update validation code (validate-defs/run-tests and friends)
3. Bump the beta-version in package.json
4. Bump the compatibleCLIRange in the cli-metadata config (to force everyone to upgrade their CLI to understand the new format)

@samwgoldman would you mind taking a crack at this?

[gabelevi]

What about

flow_>=v0.30 -> flow_v0.30- flow_<=v0.30 -> flow_-v0.30 flow_v0.30 -> flow_v0.30 flow_>=v0.30_<=v0.35 -> flow_v0.30-v0.35.0

or

flow_>=v0.30 -> flow_v0.30... flow_<=v0.30 -> flow_...v0.30 flow_v0.30 -> flow_v0.30 flow_>=v0.30_<=v0.35 -> flow_v0.30...v0.35.0

If all we need is to specify a potentially open ended range, then we can get away from the >= <= mindset