question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Docs right now -

For example:

viewer.on('error', (viewer, error, reason) => {
  console.log(`Error: ${error}, Reason: ${reason}`);
});

In addition there is ModelViewer.whenAllLoaded() which will trigger both on the idle event, and if there is currently nothing loading.

Should be -

For example:

viewer.on('error', ({ viewer, error, reason }) => {
  console.log(`Error: ${error}, Reason: ${reason}`);
});

In addition, there is ModelViewer.whenAllLoaded() which will trigger both on the idle event, and if there is currently nothing loading.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
flowtsohgcommented, Dec 1, 2020

True, however the recent changes mean that different event objects can have different properties, depending on why they were emitted, so I changed it to a simple e as is normally the notation with JS event listeners.

Thanks 😃

0reactions
arcman7commented, Dec 2, 2020

Ah, okay, yes I hadn’t actually checked out what was in that directory or read the readme. You have so much stuff! This repo is the gift that keeps on giving. I’ll continue on, and if I see room for anything I might be able to add or improve I’ll make a pr. Thanks again for being so helpful!

Read more comments on GitHub >

github_iconTop Results From Across the Web

fix README Markdown error,Let document more readale #32
There are many syntax error of Markdown in README file,I have revise it,and hope any fresher could enjoy it. This pull request changed...
Read more >
What Is README.md? How Do I Fix These Errors? - Solvusoft
README.md problems include application errors, missing files, and possible virus ... Here are the top five most common README.md problems and how to...
Read more >
Fix Pack readmes - IBM
Fix Pack readmes. For the latest information about a Fix Pack, see the appropriate Readme File. Version 9.5. Version 9.5 Fix Pack 6....
Read more >
How do I edit a project's README.md file? - Glitch Support
Open the project editor and make sure that the README.md file is selected in the file view on the left. · At the...
Read more >
Make a README
Learn how to make a great README for your programming project, and use the editable template to get started.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found