Any way to use `knex`?

Currently trying to package knex with pg. This was also a problem serverless-webpack faced but by force including the required packages it worked in the end. This is the only issue that I could find related to knex and esbuild but doesn’t seem to solve my problem.

This is the error I get when running sls package:

# ...

Serverless: Packing external modules: knex@^0.95.4, mysql, mysql2, pg@^8.6.0, pg-native, sqlite3, tedious

Error ---------------------------------------------------
 
Error: npm install failed with code 1
   at ChildProcess.<anonymous> (/home/arpad/workspace/sls-webpack-v-esbuild/esbuild/node_modules/serverless-esbuild/dist/utils.js:48:24)
   at ChildProcess.emit (events.js:314:20)
   at ChildProcess.EventEmitter.emit (domain.js:483:12)
   at maybeClose (internal/child_process.js:1022:16)
   at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)

# ...

To note that it also tries to include mysql, mysql2, pg-native, sqlite3 and tedious and I’m not sure how I can ignore them.

And this is my config:

// ...

custom: {
  esbuild: {
    bundle: true,
    minify: false,
    external: ['knex', 'pg'],
  },
},

package: {
  individually: true,
},

// ...

[arpadgabor]

Yep, now it’s working perfectly!

Serverless: Running "serverless" installed locally (in service node_modules)
Serverless: Compiling with esbuild...
Serverless: Compiling completed.
Serverless: Package lock found - Using locked versions
Serverless: Packing external modules: knex@^0.95.4, pg@^8.6.0
Serverless: Zip function: esbuild-testing-zone-dev-create - 27.95 KB [74 ms]
Serverless: Zip function: esbuild-testing-zone-dev-findById - 27.98 KB [59 ms]
Serverless: Zip function: esbuild-testing-zone-dev-find - 1.14 MB [612 ms]
Serverless: Packaging service...

Thanks a lot! Looking forward to an update with the PR and this will be great.

[olup]

Oh sorry of course, it needs deps install and building in the node modules - you cannot try it just like that - my bad. Anyway I am pretty sure it fixes your problems. I’ll add exclude anyways to the mix and let’s wait for @floydspace’s input on the PR.