Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

External dependencies bundling issue with version 1.23.4+

See original GitHub issue

I have an issue after update from version 1.23.3 to 1.23.4 It seems like this update breaks external modules bundling

I have 1 external module:

    external:
      - sharp

This module has color dependency and color has color-string dependency. So I would expect to see both modules in the /node_modules folder. However with version 1.23.4 it seems like only top level dependencies are copied to final build:

v1.23.3 with external sharp:

v1.24.4+ with external sharp:

I think it can be related to this changes in 1.23.4: https://github.com/floydspace/serverless-esbuild/commit/91f283f587c3e005aa884dc528c82c3f82bca6c8 but I’m not sure about it

Issue Analytics

State:
Created 2 years ago
Comments:6

Top GitHub Comments

1reaction

samchungycommented, Feb 7, 2022

Reverted these changes for now. Thanks for raising the issue @EugeneDraitsev. Much appreciated.

1reaction

EugeneDraitsevcommented, Feb 6, 2022

Hi, I’m using yarn 1.22.17

Top Results From Across the Web

Bundling of external deps? #230 - preconstruct ... - GitHub

Basically everywhere else than dependencies and peerDependencies because usually such tools are meant to get them and put them in external so won't...

kubernetes/CHANGELOG-1.23.md at master

A security issue was discovered in Kubernetes where users authorized to list or watch one type of namespaced custom resource cluster-wide can read...

Serverless-esbuild - npm.io

serverless-esbuild. Serverless plugin for zero-config JavaScript and TypeScript code bundling using promising fast & furious esbuild bundler and minifier.

Upgrading Tanzu Kubernetes Grid Integrated Edition (VMware ...

This topic explains how to upgrade Tanzu Kubernetes Grid Integrated Edition (TKGI) from v1.14 to v1.15 on vSphere with NSX-T networking.

Release notes — NumPy v1.24 Manual

Faster version of np.isin and np.in1d for integer arrays · Faster comparison operators ... Math C library feature detection now uses correct signatures ......