Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Prevent installation of optional peer dependencies when packaging externals

See original GitHub issue

While investigating #103 I saw that pg-native gets always bundled with pg which might not be needed by the code (if it doesn’t actually require native pg from pg). This is listed as peerDependencies, but set optional with :

"peerDependenciesMeta": {
    "pg-native": {
      "optional": true
    }
  }

We might not want to auto bundle optional peer deps in the externals @floydspace ?

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:13 (10 by maintainers)

Top GitHub Comments

1reaction

olupcommented, Mar 25, 2021

I am not sure yet, but as of now I think you are right, we should probably just implement plugins (I wanted to make a PR this week but have been delayed) and leave this as a workaround. This is a true edge-case, I think there is a questionable design from the pg library. But I can only agree with you when you note that it’s probably outside of the scope of serverless-esbuild.

0reactions

olupcommented, Apr 13, 2021

@mattisdada what about https://github.com/floydspace/serverless-esbuild/pull/113 ? Is that solving your problem ?