Extend AssemblyAssertions with methods to check on assemblies being signed or not

Background and motivation

To ensure that the public key of an signed assembly does not accidentally changes, having an assertion .HavePublicKey(string) can help. For completeness/symmetry reasons adding .BeUnsigned() might be beneficial too.

API Proposal

public class AssemblyAssertions : ReferenceTypeAssertions<Assembly, AssemblyAssertions>
{
    public AndConstraint<AssemblyAssertions> NotHavePublicKey(string because = "", params object[] becauseArgs);

    public AndConstraint<AssemblyAssertions> HavePublicKey(string publicKey, string because = "", params object[] becauseArgs);
}

API Usage

var signed = typeof(AssemblyA.ClassA).Assembly;
signed.Should().HavePublicKey("sdfds");

var unsigned = typeof(AssemblyB.ClassB).Assembly;
unsigned.Should().NotHavePublicKey();

Alternative Designs

No response

Risks

No response

[Corniel]

I see the reasoning behind .NotHavePublicKey vs .HavePublicKey. That being said, from a test a specification perspective, someAssembly.Should().BeUnsigned() tells the story better than someAssembly.Should().NotHavePublicKey(). The latter hints to something like someAssembly.Should().NotHavePublicKey("InvalidKey").

For me .HavePublicKey(key) is short for .BeSignedWithPublicKey(key), or .BeSignedWith(key), hence my original proposal.

[jnyrup]

I’ve updated the proposal with the approved API.