MethodImplAttribute doesn't work with BeDecoratedWith

Version: 5.1.2

When a method is decorated with MethodImplAttribute the assertion Should().BeDecoratedWith<MethodImplAttribute>() will not detect that and therefore produce a false negative. It’s because GetCustomAttributes method that is used behind the scenes will not get this attribute as per docs. The GetMethodImplementationFlags method has to be used. I can implement a patch for this, but I’m unsure which of two approaches would be better:

1. [breaking] add capacity of finding the Implementation Flags to current BeDecoratedWith method
2. [non-braking] add a new assertion like BeDecoratedWithImplementationFlags

[melchiork]

@dennisdoomen BeDecoratedWith itself won’t be breaking, rather a fix. However ThatAreDecoratedWith might lead to some changes in existing tests’ behavior. However it too can be considered a fix. So, this might not be breaking change after all. But the attributes itself is lost when compiling and in runtime we can only access MethodImplAttributes enum (docs). The attribute would have to be artificially “reconstructed” during assertion. Which can bring more problems. So probably the second approach would be more consistent with the framework itself. What do you think?

[jnyrup]

Thanks for another contribution @melchiork . They are very appreciated.