7.6.0 Overridden Validate methode not called

Hi, just upgraded from 7.5.2 to 7.6.0 and now behaviour is changed. Overridden ‘Validate’ is not called anymore. The validator is applied with ‘SetCollectionValidator’ and ‘SetValidator’.

Why override? To validate tree structure DTO object for example. Via property chain any errors are reported as a path in the tree. ‘Childs[2].Childs[0].Prop’.

Is this not supported anymore?

public class FooValidator : AbstractValidator<Foo>
{
    public override ValidationResult Validate(ValidationContext<Foo> ctx)
    {
        // Create ValidationResult
        // Use InstanceToValidate in ctx
        // Modify PropertyChain in ctx
        // Add erros to validation result
    }
}

[JeremySkinner]

Thanks, I should have some time on Friday to look into this.

[JeremySkinner]

This is now fixed, and I’ve released 7.6.100 - please download it and give it a try.

Some background information if you’re interested:

Every property validator has a flag called IsAsync that indicates whether it can be run asynchronously. Child validators have this marked as true as they can contain async validators of their own.

Prior to 7.6, if you call ValidateAsync on the root validator, then all property validators that are marked with IsAsync are run asynchronously, and then all validators without this flag are run synchronously. However, if you called Validate on the root validator, all child validators were run synchronously.

A fix for a separate issue changed the behaviour of Validate so that if a child validator supports async validation, it synchronusly calls its ValidateAsync. Because child validators do support being called asynchrously, this behaviour took priority over the non-async method.

The fix was to improve the async check to only run async methods when the root validator was called Asynchronously.