The 2nd fluent validator is not called when api method has 2 request models

Which version of FluentValidation are you using? <PackageReference Include="FluentValidation.AspNetCore" Version="8.6.2" />

Which version of ASP.NET are you using? <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="3.1.3" />

Describe the issue that you’re having Do you support fluent validation for this kind of controller method signature?

[HttpPut("api/content/{providerId}/{releaseAssetId}/movies")]
public async Task<ActionResult> PutMovieAsset([FromRoute] ReleaseRequestModel routeModel, 
            [FromBody] PutMovieAssetRequestModel model, CancellationToken cancellationToken)

The problem is that fluent validator of ReleaseRequestModel is called but the one for PutMovieAssetRequestModel is not.

Validators are all defined in the same project as Startup, but in their own subdirectories:

.AddFluentValidation(options =>
                {
                    options.RunDefaultMvcValidationAfterFluentValidationExecutes = true;
                    options.ImplicitlyValidateChildProperties = true;

                    options.RegisterValidatorsFromAssemblyContaining<Startup>();
                })

[JeremySkinner]

Hi,

I just tried this and can’t reproduce the problem - it worked correctly for me. Both validators were instantiated and executed, and both sets of validation failures were added to ModelState.

Please put together a small sample application that reproduces the issue (ideally in a github repo that I can pull down) then I’ll be able to investigate further. Thanks.

[lnaie]

Thanks for this.

The problem is your PutMovieAssetRequestModelValidator has an open generic type parameter - this won’t be registered with the container or instantiated automatically, as there’s no way to know automatically what type should be used. You need to remove the open generic - once removed it’ll work correctly.

// Change from
public class PutMovieAssetRequestModelValidator<T> : PutStreamableRequestModelValidator<PutMovieAssetRequestModel> { }
// to
public class PutMovieAssetRequestModelValidator : PutStreamableRequestModelValidator<PutMovieAssetRequestModel> { }

That makes sense indeed, top level validators don’t have to use generic types. Leftover from some previous code changes. Thanks