When(bool) not working with SetValidator on property

Issue Description

I have the class EventViewModel that has a complex property SeriesScheduleViewModel

public class EventViewModel
{
     public string Name {get;set;}
     public string LocationName{get;set;}
     public bool IsSeriesEvent {get;set;}

     public SeriesScheduleViewModel SeriesSchedule {get;set;}
     ...
}

SeriesScheduleViewModel class contains a colection of SeriesViewModel :

public class SeriesScheduleViewModel
{
     public IList<SeriesViewModel> Series { get; set; }

     public string TimeZoneId { get; set; }
     public IList<Range<DateTime>> ExtraDates { get; set; }
     public IList<DateTime> ExceptDates { get; set; }
}

And the SeriesViewModel looks as it follows:

public class SeriesViewModel
{
    public SeriesType SeriesType { get; set; }
    public int DailyInterval { get; set; }
    public int WeeklyInterval { get; set; }
    public string SelectedDaysOfWeek { get; set; }
    ....
}

Validator classes:

 public class EventValidator: AbstractValidator<EventViewModel>
    {
        public EventUpdateValidator()
        {
          RuleFor(x => x.SeriesSchedule).SetValidator(new SeriesScheduleValidator()).When(x => x.IsSeriesEvent);
        .....
        }
    }

The validation for the Series property of SeriesSchedule is made with SetCollectionValidator:

 public class SeriesScheduleValidator : AbstractValidator<SeriesScheduleViewModel>
    {
        public SeriesScheduleValidator()
        {
            RuleFor(x => x.TimeZoneId).NotEmpty();
            RuleFor(x => x.Series).SetCollectionValidator(new SeriesValidator());
            ......
        }
    }

public class SeriesValidator : AbstractValidator<SeriesViewModel>
    {
        public SeriesValidator()
        {
            RuleFor(m => m.DailyInterval).NotEmpty().When(m => m.SeriesType == SeriesType.Daily);
            RuleFor(m => m.WeeklyInterval).NotEmpty().When(m => m.SeriesType == SeriesType.Weekly);
            ...
         }
     } 

The problem that I have is that the SeriesSchedule and it’s complex properties validation gets executued regardless of whether the IsSeriesEvent is set to true or false;

[emanu11]

Uhh, yea. After looking again in the whole application, I just realized that I am using the IoC container integration that has all viewModels registered there. I said that there were none of the supported ways for wiring up the ViewModel to the validator because I couldn’t find any reference to the EventViewModel (such a childish mistake)

  FluentValidationModelValidatorProvider.Configure(p =>
                {
                    p.ValidatorFactory = new ModelValidatorFactory(typeof(ModelValidators.Namespace));
                });

Thanaks for your help!

[JeremySkinner]

How are you wiring up the model to the validator for automatic integration at the moment? The only 2 supported ways are either with the ValidatorAttribute or with an IoC container. You must be using one of these approaches if it’s running at the moment.