Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

IsHidden() causes a forced reflow

See original GitHub issue

There’s probably something about the getComputedStyle that forces the browser to reflow, creating a performance bottleneck. https://gist.github.com/paulirish/5d52fb081b3570c81e3a#calling-getcomputedstyle

I wonder if there could be an alternative?

https://developers.google.com/web/fundamentals/performance/rendering/avoid-large-complex-layouts-and-layout-thrashing?utm_source=devtools#avoid-forced-synchronous-layouts

Issue Analytics

State:
Created 3 years ago
Reactions:2
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

stefcameroncommented, Apr 17, 2021

The next publish of this library will update tabbable to 5.2.0, which will give focus-trap the ability to pass the new displayCheck option down to tabbable, which could help mitigate this issue. However, this could open a can of worms for focus-trap as I noted in #362. Comments welcome.

1reaction

pythecommented, Oct 15, 2020

I see this in Chrome 86 on MacOS 10.15.7, and in Edge 84 on Windows 10 (in a VM).

I’m experiencing the same issue and interested in investigating an optimization here. In my case, an extremely large document exacerbates the problem: Each forced layout takes 600+ms. Removing the need for this recalculation would halve the execution time of my callback.