Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Code base needs to be modernized to drop findDOMNode and string refs

See original GitHub issue

The following lint issues had to be disabled in order to maintain long backward compatibility to React 16.0:

react/no-find-dom-node: Suggested solution is to use callback refs.
react/no-render-return-value: See deprecation warning. Suggested solution is to use callback refs.
react/no-string-refs: Suggested solution is to use callback refs.

TL/DR: Using callback refs should clear all these up.

Sooner or later, however, these issues will have to be rectified in order for the code to be compatible with the next major release of React, at which point, we’ll have to drop support for < React 16.3 which is when React.createRef() and callback refs were introduced (AFAICT).

Issue Analytics

State:
Created 3 years ago
Reactions:4
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

stefcameroncommented, Apr 30, 2022

@m7kvqbe1 Thanks for letting me know. As it stands, this would be the next priority to work on for this project, provided nothing more urgent arises in the meantime. I can’t make promises on a timeline, however. Just hopefully “soon”. Issues on focus-trap and tabbable could also detract from this, but as of this past Thursday, I think I finally got all 3 in a good place again. 😅

0reactions

stefcameroncommented, Jun 10, 2022

Look for a fix to this (I hope!!) in v9.0.0 being published right now.