FocusTarget Typing Suggestion

version: "focus-trap-react": "^8.7.1"

I recently needed to use focusTrapOptions.initialFocus

initialFocus?: FocusTarget | false;

I tried using HTMLDivElement, but I got an error. Looking at global.d.ts, HTMLDivElement extends HTMLElement, so the suggestion would be to add a generic type, eg:

export type FocusTarget<T extends HTMLElement> = T | SVGElement | string | { (): T | SVGElement };

so that all elements that are extended from HTMLElement be accepted.

[stefcameron]

Once the other focus-trap changes are merged, I’ll publish focus-trap and then publish focus-trap-react to update its dependency on focus-trap, and then you’ll have all the right typings.

[stefcameron]

OK, great! So that’s basically what we have now (just hasn’t been published yet because there are a few changes in flight still that I’m waiting on to be done). See https://github.com/focus-trap/focus-trap/blob/master/index.d.ts#L14