Unexepected behavior with base classes

Caliburn.Micro 3.1.0 PropertyChanged.Fody 2.1.1 Not calls NotifyOfPropertyChange() for property HasComplexClassConflict when Building changed in this case:

  public class BuildingCardViewModelBase : CardViewModelBase
    {
           public Building Building { get; set; }
    }

public class OperatorBuildingCardViewModel : BuildingCardViewModelBase
    {
            public bool HasComplexClassConflict
            =>
                Building?.Conflict != null &&
                Building.Conflict.Any(x => x.ConflictValueType == ConflictValueType.ComplexClass);
    }

Still not calls NotifyOfPropertyChange() for property HasComplexClassConflict when Building changed in this case:

  public class BuildingCardViewModelBase : CardViewModelBase
    {
           public virtual Building Building { get; set; }
    }


public class OperatorBuildingCardViewModel : BuildingCardViewModelBase
    {
          //! Added Building property overriding
           public override Building Building { get; set; }
           
           public bool HasComplexClassConflict
            =>
                Building?.Conflict != null &&
                Building.Conflict.Any(x => x.ConflictValueType == ConflictValueType.ComplexClass);
    }

Calls NotifyOfPropertyChange() for property HasComplexClassConflict when Building changed only in this case:

  public class BuildingCardViewModelBase : CardViewModelBase
    {
           public virtual Building Building { get; set; }
    }


public class OperatorBuildingCardViewModel : BuildingCardViewModelBase
    {
           //! Notifying manually added
           [AlsoNotifyFor(nameof(HasComplexClassConflict)]
           public override Building Building { get; set; }
           
           public bool HasComplexClassConflict
            =>
                Building?.Conflict != null &&
                Building.Conflict.Any(x => x.ConflictValueType == ConflictValueType.ComplexClass);
    }

I expected it should work in case 1. Great library!

[SimonCropp]

@AsValeO in theory it probably could. But it would be enabling a design that will cause you long term pain. You would be much better served long term by just duplicating the Building property in child classes. If u need to treat the base in common code scenarios then you can achieve this using an interface instead of a base class

[distantcam]

Case 1 is not possible because the notification for the subclass OperatorBuildingCardViewModel has to be done in the base class BuildingCardViewModelBase which is bad object orientation. A base class should not know about subclasses.

I would have thought case 2 would work, but I’m not certain. @SimonCropp can you confirm?