[Modal] onApprove cannot prevent hiding when modal is created with JS API.

Bug Report

As per documentation (and module code), if onApprove callback returns false then modal should not be hidden on clicking approval button. But it still hides.

onApprove return value checked in: https://github.com/fomantic/Fomantic-UI/blob/e39a0ae5183c12808ba1eee82082efbb15f4d450/src/definitions/modules/modal.js#L322

Steps to reproduce

1. Create modal with JS API
2. Show modal
3. Click approval button

Expected result

Modal should not be hide.

Actual result

Modal hides.

Testcase

https://jsfiddle.net/pbcr1qL5/5/

Version

2.8.8

[lubber-de]

Fixed by #2108

[lubber-de]

Confirmed. Also happens with onDeny

Reason explained

Actions provided via JS parameters do have a default click handler to hide the modal if no click handler is given or, if given, does not return false.

The onApprove event in this case is triggered additionally, because this was originally invented to auto attach events to pre-existing action buttons in a modal already created in the DOM tree.

So, your buttons have actually 2 handlers, the onapprove was indeed not hiding the modal, but the automatically created button trigger was (because you did not provide a click handler for the action button.

We will create a fix for this.

In the meantime you can use one of the following workarounds

a) Change the color from positive to green and use a click handler instead ot the onApprove callback https://jsfiddle.net/lubber/np2bdLew/7/

b) Add a click handler to your positive action which returns false and still use the onapprove callback https://jsfiddle.net/lubber/np2bdLew/6/

c) Keep your positive class, but set the internal selector for approve buttons to something not existing like a space string https://jsfiddle.net/lubber/np2bdLew/10/