[fealib] lookup flag ignored if it's declared before a script statement

In the following lookup, the lookup flag will be ignored which is different from FDK. In FDK it’s not ignored.

    lookup rlig_arab_0 {
        lookupflag RightToLeft IgnoreMarks;
        script arab;
        sub arAlef arLamPF.i arLamPF.m arHehPF.f by arAllah;
    } rlig_arab_0;

But if I move the flag after the script statement, it will be taken:

    lookup rlig_arab_0 {
        script arab;
        lookupflag RightToLeft IgnoreMarks;
        sub arAlef arLamPF.i arLamPF.m arHehPF.f by arAllah;
    } rlig_arab_0;

This is not a major issue as long as the user knows about this difference. I had a situation that I couldn’t find an explanation why my lookup flag is ignored in fontmake but not in makeotf.

[khaledhosny]

https://github.com/fonttools/fonttools/pull/1883 should fix the output to match makeotf’s, but note that the first rlig lookup will still have its lookup flags reset (in both makeotf and feaLib) because the current script is different from the new one. Since all lookups in your rlig feature use the same script, you should set it outside the lookup blocks instead (also RightToLeft has effect only on cursive attachment lookups, it is ignored by layout engines for all other lookups, so you don’t need to set it).

[khaledhosny]

Sorry for the delay, I got the files, and I checked what makeotf is doing, but got distracted. Will make a PR soon.