question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

XML format does not retain LookupType for lookups with no subtables

See original GitHub issue

Eg, we currently can only encode:

<Lookup index="1" empty="1"/>

the LookupType is implied by the type of the subtables. If there’s no subtable, we don’t record lookup type and roundtripping changes it (probably to zero).

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:15 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
behdadcommented, Jan 5, 2017

Easy everyone… First keep it simple. Second, having to write ChangeLog brings back ancient memories. Either we should autogenerate ChangeLog from git log (I do that in HarfBuzz and other projects), or, a high-level summary of big and user-facing changes should be put in NEWS, in which case not every commit should touch it.

My bikeshed-detector has been buzzing more frequently than I like recently 😉.

0reactions
anthrotypecommented, Jan 9, 2017

I don’t think NEWS should become an auto-generated mirror of git log; I’d prefer to keep it as it is now, i.e. like Behdad put it:

a high-level summary of big and user-facing changes

We just need to remember to update it when we make such changes.

Read more comments on GitHub >

github_iconTop Results From Across the Web

fonttools/otTables.py at main - GitHub
A library to manipulate font files from Python. Contribute to fonttools/fonttools development by creating an account on GitHub.
Read more >
OpenType Specification Change Log - Microsoft Learn
Clarified where functions and instructions can or cannot be defined or redefined, and the persistence of definitions.
Read more >
Older changes to FontForge
If a contextual chaining pos/sub in a sfd file referred to a non-existant lookup we would insert a NULL lookup into a rule....
Read more >
How to retain the content format after transform in XML file
1 Answer 1 ... If you convert your XDocument to an XmlDocument, you can use the PreserveWhitespace flag to make sure that the...
Read more >
OpenType Feature File Specification | afdko - GitHub Pages
A feature file glyph class is also used to represent the set of alternate glyphs in an alternate substitution lookup type rule. 2.g.i....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found