Java Version Detection doesn't work on all version strings

Looking here https://github.com/forcedotcom/salesforcedx-vscode/blob/master/packages/salesforcedx-vscode-apex/src/requirements.ts line 86

javaHome + '/bin/java', ['-version'], {},

      (error, stdout, stderr) => {

        if (

          stderr.indexOf('build 1.8') < 0 &&

          stderr.indexOf('build 11.') < 0

        ) {

          reject(nls.localize('wrong_java_version_text', SET_JAVA_DOC_LINK));

        } else {

          resolve(true);

        }

      }

I’m using openJDK and it looks like my output is different

_Originally posted by @Londoner1234 in https://github.com/forcedotcom/salesforcedx-vscode/issues/930#issuecomment-495531429_

[shillem]

Please, consider adding 12 already since it’s GA

[sogeisetsu]

Please, consider adding 12 already since it’s GA

@shillem OH ! NO ！I tried to use the GA version of openjdk11 and the GA version of openjdk17, but it didn’t work, I also used the build 11.0.2+9 version of openjdk, luckily it worked. When I change to Oraclejdk11 or Oraclejdk17, it works fine.

There is one thing I don’t understand, is there any logic for salesforcedx-vscode in the selection of supported openjdk versions? Why does not support the GA version of opengdk ? @shillem GA clearly means General Availability, which represents the officially released version, the official began to recommend widespread use.

I got openjdk from this website👉https://jdk.java.net/archive/