Windows version conditions do not apply for Windows 10

Some artifacts have conditions in the form of os_major_version >= X AND os_minor_version >= Y. This fails starting with Windows 10, which can have version 10.0. A condition like os_major_version >= 6 AND os_minor_version >= 1 will fail here although the artifact applies.

One example is https://github.com/ForensicArtifacts/artifacts/blob/015b37543d97ad719f92d51b0a6cd548e4b9dab6/data/windows.yaml#L1335

I can think of multiple solutions to this:

• More complicated conditions like (os_major_version >= 6 AND os_minor_version >= 1) OR os_major version >= 7
• A semantic version compare, something like os_version >= "6.1"

[joachimmetz]

What are you specifically referring to when you say can it all together?

I mean removing it. What is the value it adds? Let me check with the GRR folks but this might be a left over from early days.

[joachimmetz]

Removed conditions https://github.com/ForensicArtifacts/artifacts/pull/515

Rationale: os_major_version and os_minor_version use the kernel version. Artifact definitions are typically product level specific not kernel level.