Consider merging into eslint-plugin-jsx-a11y
See original GitHub issueHi folks! Just ran into this and I think it’s awesome; thanks for all the work you’ve done here. I filed https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/287 a while ago to do exactly this. I’m here to ask if you’d consider merging this plugin into one tool.
Why?
At Twitter, we use react-native-web. For us eslint-plugin-jsx-a11y
provides little to no support, but sometimes it’s useful when we need to fallback to DOM elements for one reason or another. IMO having two packages is a nice separation of concerns, but adds a level of indirection for users who need to rely on both. For one, I didn’t see this until at least 10 months later 🤷♂️ . I know that at Twitter, we could definitely benefit from using both whether it’s one plugin or two.
Proposal
Add these rules to eslint-plugin-jsx-a11y
under a native
namespace OR add a global setting to eslint-plugin-jsx-a11y
to specify platform (web, native, both). I’d prefer namespacing since that allows users to opt-in to any rule that suits their project.
How
Add these rules in the next upcoming minor release with a suggested native
config.
I’m suggesting moving to jsx-a11y
for two reasons:
- Pre-existing support and use.
- The name is not restrictive of platform, just syntax. (In hindsight, I wish I had just named it
eslint-plugin-accessibility
😄 )
Thoughts?
Issue Analytics
- State:
- Created 5 years ago
- Comments:6 (1 by maintainers)
Top GitHub Comments
The reason we created our own instead of merging it into
eslint-plugin-jsx-a11y
is that theirs focuses on react-agnostic web, while this one focuses on react-native, specifically. There is no rule overlap.Though the eslint dependencies do overlap as we forked from that project originally, npm and yarn consolidate those dependencies into a single reference in node_modules, so there isn’t a lot of duplication.
I’m in no rush to merge projects 😃 Seems like a lot of work for a risky payout.