question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Consider merging into eslint-plugin-jsx-a11y

See original GitHub issue

Hi folks! Just ran into this and I think it’s awesome; thanks for all the work you’ve done here. I filed https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/287 a while ago to do exactly this. I’m here to ask if you’d consider merging this plugin into one tool.

Why? At Twitter, we use react-native-web. For us eslint-plugin-jsx-a11y provides little to no support, but sometimes it’s useful when we need to fallback to DOM elements for one reason or another. IMO having two packages is a nice separation of concerns, but adds a level of indirection for users who need to rely on both. For one, I didn’t see this until at least 10 months later 🤷‍♂️ . I know that at Twitter, we could definitely benefit from using both whether it’s one plugin or two.

Proposal Add these rules to eslint-plugin-jsx-a11y under a native namespace OR add a global setting to eslint-plugin-jsx-a11y to specify platform (web, native, both). I’d prefer namespacing since that allows users to opt-in to any rule that suits their project.

How Add these rules in the next upcoming minor release with a suggested native config.

I’m suggesting moving to jsx-a11y for two reasons:

  1. Pre-existing support and use.
  2. The name is not restrictive of platform, just syntax. (In hindsight, I wish I had just named it eslint-plugin-accessibility 😄 )

Thoughts?

cc/ @jessebeach @ljharb @necolas @comp615

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (1 by maintainers)

github_iconTop GitHub Comments

3reactions
knitcodemonkeycommented, Oct 29, 2018

The reason we created our own instead of merging it into eslint-plugin-jsx-a11y is that theirs focuses on react-agnostic web, while this one focuses on react-native, specifically. There is no rule overlap.

Though the eslint dependencies do overlap as we forked from that project originally, npm and yarn consolidate those dependencies into a single reference in node_modules, so there isn’t a lot of duplication.

1reaction
jessebeachcommented, Oct 16, 2018

I’m in no rush to merge projects 😃 Seems like a lot of work for a risky payout.

Read more comments on GitHub >

github_iconTop Results From Across the Web

eslint-plugin-jsx-a11y - npm
This plugin does a static evaluation of the JSX to spot accessibility issues in React apps. Because it only catches errors in static...
Read more >
eslint-plugin-jsx-a11y | Yarn - Package Manager
Fast, reliable, and secure dependency management.
Read more >
Run global ESLint with plugin eslint-plugin-jsx-a11y
This issue is caused by the changes to the way ESLint loads packages between versions 5 and 6. See here for details. Plugins...
Read more >
eslint-plugin-jsx-a11y - Splunk Documentation
Merging 3 interlinked large data sets with differe... interlinked Dashboard ... https://github.com/evcohen/eslint-plugin-jsx-a11y.
Read more >
eslint-plugin-jsx-a11y: Popularity and Maintenance Insights
I'm a software engineer at @facebook working on Lexical. Author of Lexical, @infernojs and t7. Enjoys coding + being a dad. Former React...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found