CJS + ESM Question/discussion

React Popper pulls in via import isEqual from 'react-fast-compare'; and this is failing in Rollupjs which states default is not exported from [module].

Would it be possible for the package that is released to npm contain a cjs and an esm file? This would allow for require() statements as well as import.

I’ll happily put a PR together if this is desired, but wanted to know where the thoughts were in the project before putting in the effort.

I have this working now using patch-package with the following patch:

diff --git a/node_modules/react-fast-compare/index.js b/node_modules/react-fast-compare/index.js
index 1301ff0..3fa4874 100644
--- a/node_modules/react-fast-compare/index.js
+++ b/node_modules/react-fast-compare/index.js
@@ -115,7 +115,7 @@ function equal(a, b) {
 }
 // end fast-deep-equal
 
-module.exports = function isEqual(a, b) {
+function isEqual(a, b) {
   try {
     return equal(a, b);
   } catch (error) {
@@ -132,3 +132,5 @@ module.exports = function isEqual(a, b) {
     throw error;
   }
 };
+
+export default isEqual;

[apipkin]

I can confirm, putting the commonjs plugin before the babel plugin solved this. Not certain why that didn’t work yesterday during my testing, but glad it’s working today… ship it, amiright?

[kitten]

Usually the commonjs module in Rollup should be placed pretty early in the pipeline, like after resolve, so it may be as simple as that in this case.