Configuration is cached between authorize calls

Issue

When calling authorize method with different configuration, on the second time the configuration is taken from the first call - it is cached after first call.

The problem exist in version v4.4.0, but not in v4.3.1. I believe that the issue was introduced in this commit: https://github.com/FormidableLabs/react-native-app-auth/commit/44a47c524dd20ec47595ece6730f650d70ac6078

The mServiceConfiguration is taken instead of serviceConfiguration, which is ok for the first time or for using prefetching, and the field is not cleared when closing the chrome tab.

Steps to reproduce:

1. call authorize with issuer X
2. do not log in, just close the tab
3. call authorize with issuer Y

Result: tab is opened with issuer X Expected result: tab is opened with issuer Y

---

Environment

• Your Identity Provider: my own
• Platform that you’re experiencing the issue on: Android
• Are you using Expo?: no

[mklekowski]

@tuananhluong I do not know very well the code, but as far as I understand this line (https://github.com/FormidableLabs/react-native-app-auth/blob/master/android/src/main/java/com/rnappauth/RNAppAuthModule.java#L168) should look different. It should check if the prefetched configuration didn’t changed (probably the simples way is to cache configuration by the issuer or just check if the issure is different).

In my project I reverted to 4.3.1. I hope that authors of this project know how to fix it more than I, but maybe on the weekend I’ll try to figure out how to fix it.

[ThomasLarge]

This is still an issue on the current version:

For me, the fix is in the config that is passed to any of the functions, if you use issuer and use more than one OAuth client it caches the details and effects all calls (Auth, Refresh) but if you map out all of the serviceConfiguration and remove issuer you don’t get this issue.