question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`website`: Add quality checks.

See original GitHub issue

We need to add all the following to website/package.json wireit tasks:

  • lint
  • lint:fix
  • prettier
  • prettier:fix
  • types:check (Note – this is blocked by #1201 )

Then:

  • Integrate all those checks in root aggregate tasks in package.json
  • Remove paths-ignore in main CI workflow so we do all docs code checking there
  • However, let’s keep the build task in website out of both wireit and CI and leave it to just the docs workflow.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:11 (11 by maintainers)

github_iconTop GitHub Comments

1reaction
ryan-roemercommented, Aug 25, 2022

@paulmarsicloud I’m happy to pair up tomorrow in this if you want fresh eyes.

I would expect yarn and pnpm to be very different for installed modules because of how they work. But pnpm is more strict for things like phantom dependencies so may be that too

1reaction
ryan-roemercommented, Aug 23, 2022

That sounds right. What I think is happening is that the fix task actually runs the check first, to take advantage of caching, and then if it fails runs the actual fixing task. So there is an intermediate failure if the fix task actually mutates files. And that’s all as expected

Read more comments on GitHub >

github_iconTop Results From Across the Web

Website Quality Assurance (QA): The Optimizer's Guide - CXL
Website quality assurance, frequently referred to as QA, pairs optimizers and developers to ensure everything looks and works correctly on all ...
Read more >
8 Crucial Website Quality Assurance Factors (and How to Test ...
The 8 Website Quality Assurance Factors Which Need to Be Tested · 1. Broken Links · 2. Missing or Incorrect Content · 3....
Read more >
Your Complete Guide to Website QA (Quality Assurance) with ...
Website QA, or Quality Assurance is the process of testing a website in order to discover mistakes or errors that may not have...
Read more >
Website Quality Assurance, Protect Your UX
While it is easy to get caught up in creative design & functionality, website quality assurance (QA) is critical. Checkout our downloadable QA...
Read more >
Quality Assurance Checks Before Launching a Website
Quality assurance checks refer to a process of ensuring everything on your website is set-up and working as it should – from code...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found