Formsy onChange model missing value object methods

Hi,

For context I have created a datepicker using withFormsy(). The date selected by the user is a Moment.js object which has a bunch of methods for manipulating and formatting the date.

The model on the Formsy prop onChange((model)=>{ }) remove all the __proto__ methods on the object.

I think this is down to the cloneIfObject() method in https://github.com/formsy/formsy-react/blob/6fcc682e1dae82dd5643a744f587713f4d8a9ced/src/utils.ts#L47 which is spreading the current model values.

This doesn’t seem to be the same behaviour with setting the value using the setValue() prop in the withFormsy component.

This was working pre the v1 to v2 update.

Is the cloneIfObject method needed?

Many thanks

[wkerswell-gresham]

After some playing yesterday I have worked around it by using the model value to create another moment object.

  const onChange = ({date}) =>{
      if(date){
        const momentDate = moment(date);
        ...
      }
  }

Makes sense what you are saying about only supporting the JSON so happy for this issue to be closed. Thanks

[rkuykendall]

It doesn’t appear so. I’m going to write a test-case to get more definitive information.

Also, one additional option is that objects like this just shouldn’t be supported. In that case, you would want to use something like an ISO 8601 string as your actual “value” and either use moment only internally in your input component, only external to the form, or in both. What do you think about that?

There’s some sense in formsy only supporting things that could be sent to or from a server as JSON.