Test explorer does not display tests after update

After the last update on 9-11 I get an error popup from the bottom right of visual studio code that says “container[title].push is not a function”. This happens every time I press the refresh button. Below is a log output of the test discovery which all seems fine.

Starting extension Finding projects for pattern /Users/cmorris/Dev/Science/UnitTestsNetCore/UnitTests.csproj Found 1 matches for pattern Evaluating match /Users/cmorris/Dev/Science/UnitTestsNetCore/UnitTests.csproj Adding directory /Users/cmorris/Dev/Science/UnitTestsNetCore Executing dotnet test -t -v=q in /Users/cmorris/Dev/Science/UnitTestsNetCore Executing dotnet vstest "/Users/cmorris/Dev/Science/UnitTestsNetCore/bin/Debug/netcoreapp2.1/UnitTests.dll" /ListFullyQualifiedTests /ListTestsTargetPath:"/var/folders/_r/7hzckl0x1f9_93ywbm_sx4c40000gq/T/test-explorer-discover-v8ULrG/output.txt" in /Users/cmorris/Dev/Science/UnitTestsNetCore Discoverd tests with nunit. Found 3334 in 1 directories

Extension Info: .Net Core Test Explorer 0.5.3 (2018-09-11) VSCode Info: Version 1.27.2 (1.27.2)

[stefanforsberg]

@cmorris98 @TrevorVonSeggern @dchw

Looks like this is an actual bug in vstest (https://github.com/Microsoft/vstest/pull/1677). Our extension previously hid this error but now we don’t anymore (to be able to support named test fixtures).

Until this fix in vstest is shipped what we can do is to not blow up the whole extension when this error occur. That will mean that these tests does not show up in the tree but the other ones will. I’m not sure that’s a good enough state for you guys in the meantime but it’s the best we can do.

[stefanforsberg]

@cmorris98 Yes, we changes so failure to parse one test does not break the tree. If you’re still using nunit you will still hit the bug I mentioned (https://github.com/formulahendry/vscode-dotnet-test-explorer/issues/145#issuecomment-422093742) but it should just affect tests that suffers from that bug.