Feature request: Fontawesome custom kit module for icon library
See original GitHub issueDescribe the problem you’d like to see solved or task you’d like to see made easier
I’m trying to set up my fontawesome custom kit with custom icons to become a module where I can import like the following
import { fas } from ‘@fortawesome/free-solid-svg-icons’; import { far } from ‘@fortawesome/free-regular-svg-icons’; import { fak } from ‘@fortawesome/my-custom-fontawesome-kit’;
export class AppModule { constructor(library: FaIconLibrary) { library.addIconPacks(fas, far, fak); } }
Is this in relation to an existing part of angular-fontawesome or something new?
I believe this is something new as the fontawesome kit is relatively new
What is 1 thing that we can do when building this feature that will guarantee that it is awesome?
Making integration of custom fontawesome kit with angular seamless.
Why would other angular-fontawesome users care about this?
As more users start creating their own kits, they’ll want to have the same implementation of icon library. It solves the issue of tree shaking since there isn’t any tree to shake when all the icons you ever want for the application you’re building is all in one library package.
On a scale of 1 (sometime in the future) to 10 (absolutely right now), how soon would you recommend we make this feature?
10 Absolutely right now. Otherwise, why would loyal, paying customers use the fontawesome kit, there are other solutions for custom icon kits out there.
Feature request checklist
- This is a single feature (i.e. not a re-write of all of Font Awesome)
- The title starts with "Feature request: " and is followed by a clear feature name (Ex:
Feature request: moar cowbell
) - I have searched for existing issues and to the best of my knowledge this is not a duplicate
Issue Analytics
- State:
- Created 3 years ago
- Comments:10 (2 by maintainers)
We’ve been able to resolve the issue that @Unidraga had with using custom icons.
Regarding using Kits with the angular-fontawesome project: here are our (Font Awesome) thoughts on this.
The Kits product and the angular-fontawesome project are orthogonal to each other. We believe that if you are using Angular that angular-fontawesome is the best choice. The work that @devoto13 and the rest of the community have put in to this makes it the best choice and it’s our first recommendation when any of our free or pro customers ask us.
The only wrinkle with this is that Kits provides a convenient way to upload custom icons that would then be valuable to use within an Angular project (via angular-fontawesome). So what we are committed to is making some of the features of Kits usable with our JavaScript frontend frameworks.
What this might mean is that you have an npm-installable package that uses our private NPM registry that includes the custom icons you’ve uploaded into your Kit. So using your custom icons is familiar and is supported without any additional work from the framework packages (like angular-fontawesome).
Something like this:
Nothing is set in stone other than the fact that we know we have some features from Kits that would be valuable to all of our JS component package frameworks. We certainly want to open this capability up because we think it’s pretty friggin’ cool 😃
@robmadole Oh! So that’s what he meant when he said he’s only maintaining the library and not working for FA. Will do!
I’ve got an email thread started in support with Trevor so I’ll use that channel instead. Thanks for your patience and guidance @devoto13 , you’ve been awesome and I appreciate it greatly.