All icons are bundled unless explicitly specified

When switching from ember-font-awesome to ember-fontawesome I noticed the following payload changes for my app that uses about 30 icons.

Asset	FA 4	FA 5	Diff
vendor.js	545 KB	761 KB	+216 KB
font	67 KB	0 KB	-67 KB
app.css	31 KB	23.9 KB	-7.1 KB

So overall, an increase of 141.9 KB from the switch.

I have not added anything to my ember-cli-build.js, and I’m using both the fontawesome-free-brands and fontawesome-free-solid packages on v5.1.0-3. These were installed with yarn add [pkgname] per the readme (not dev dependencies).

From this comment I was under the impression that this addon implemented tree shaking to get rid of unused icons. Is that not the case? Is there something else I need to do to get the build size back down?

[bgentry]

I think it’s reasonable to expect folks to whitelist the dynamic icons they want to include. The “all” option makes it easy for people who really don’t care about payload size and just want it to work.

The truly bad part of the whitelisting experience is that users have to restart their app server each time they want to add an icon to the list and have it be available in development. But I don’t think there is any way to avoid that in dev while still warning them about non-whitelisted icons, is there?

[jrjohnson]

I’m not sure what we should optimize for here. The Ember way is generally to provide the best experience possible with the least configuration. In this case though I think a minimal build is the best experience. Since it looks like it will be possible to handle static icon names in a transform it won’t require a lot of work on a developers part to just register their dynamic icons (especially since missing icons throw a console error). If we leave icons in by default then it becomes much more annoying later to attempt to discover which icons are missing once a developer realizes that they can save a lot of file size by doing so.