Icon sizes changed after upgrading

Describe the bug After upgrading to 0.3.0 I noticed that the size of some icons changed. For instance, ellipsis-v is displayed much smaller than expected, and angle-down/angle-up also look smaller.

Reproducible test case Upgrade to 0.3.0 then use <FaIcon @icon="ellipsis-v" />.

Expected behavior I ran a diff between the icons rendered in 0.2.3 and 0.3.0: The lack of ID and ember-view class is expected with Octane, but the viewBox should be identical.

Desktop

• Browser Chrome
• Version 97

I hope there was enough helpful information? What’s weird is that it’s only happening with a few icons 🤔

[jrjohnson]

Thanks @st-h for tracking this down. I merged your PR and I’ve request a release from the Fortawesome team.

Aside: I also hate the icons.js file, but haven’t come up with anything better. I’m very much hoping that once RFC 779 lands with first class imports in template we can do away with most of the build tooling here and just import directly from node_modules for any icon. Since this solves so many problems I’m not terribly worried about making a better interim solution here. I’m happy to merge stuff though if there are improvements you can see.

[st-h]

@gzurbach thanks for opening this. I was wondering why I was unable to center my icons, even though it seemed to work flawlessly in the past. With 0.3.0 the icon seemed to be overflowing. Turns out the incorrect viewBox is the culprit here as well.

0.2.2:

0.3.0: